Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide time if discharge reason: Referred / LAMA / Recovered #5434

Merged
merged 1 commit into from
May 4, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented May 4, 2023

WHAT

🤖 Generated by Copilot at f845e53

Updated formatDate function to accept a format argument and applied it to discharge date in ConsultationDetails.tsx. This improves the consistency and readability of the date display in the facility dashboard.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at f845e53

  • Modify formatDate function to accept date format as second argument (link, link)
  • Use consistent format of DD/MM/YYYY for discharge date in ConsultationDetails.tsx (link, link)

@rithviknishad rithviknishad requested a review from a team May 4, 2023 08:09
@rithviknishad rithviknishad requested a review from a team as a code owner May 4, 2023 08:09
@rithviknishad rithviknishad requested a review from gigincg May 4, 2023 08:09
@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview May 4, 2023 8:09am

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f845e53
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64536832d3dfb100088ac27b
😎 Deploy Preview https://deploy-preview-5434--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label May 4, 2023
@nihal467
Copy link
Member

nihal467 commented May 4, 2023

LGTM

@khavinshankar khavinshankar merged commit dacee5e into develop May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the fix-5433 branch May 4, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Time reflection in discharge reason for recovered, referred, and LAMA
3 participants