Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show selected consultation's facility name instead of patient's last consultation's facility name #5452

Merged
merged 2 commits into from
May 5, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented May 5, 2023

WHAT

🤖 Generated by Copilot at b6e244d

Fixed a bug where the facility link in the patient info card could point to the wrong facility. Used the consultation object to get the correct facility name and link in PatientInfoCard.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at b6e244d

  • Fix the facility link and name in the patient info card component (src/Components/Patient/PatientInfoCard.tsx)
  • Use the consultation object instead of the patient object for the href and text content of the Link component (link, link)

@rithviknishad rithviknishad requested a review from a team May 5, 2023 13:03
@rithviknishad rithviknishad requested a review from a team as a code owner May 5, 2023 13:03
@rithviknishad rithviknishad requested a review from bodhish May 5, 2023 13:03
@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 1:30pm

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f0357ce
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/645504b577f1ca0008f55664
😎 Deploy Preview https://deploy-preview-5452--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label May 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad rithviknishad added urgent P1 breaking issue or vital feature labels May 5, 2023
@nihal467
Copy link
Member

nihal467 commented May 5, 2023

LGTM

@khavinshankar khavinshankar merged commit 78c72db into develop May 5, 2023
@khavinshankar khavinshankar deleted the rithviknishad-patch-1 branch May 5, 2023 14:10
@github-actions
Copy link

github-actions bot commented May 5, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consultation history is showing wrong facility name
3 participants