Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced Material UI components with Form component in DeathReport.tsx #4939 #5487

Closed
wants to merge 3 commits into from
Closed

Replaced Material UI components with Form component in DeathReport.tsx #4939 #5487

wants to merge 3 commits into from

Conversation

print-Sathvik
Copy link
Contributor

Proposed Changes

  • Replaced InputLabel of Material UI with FieldLabel component of Form
  • Replaced PageTitle with Page

@print-Sathvik print-Sathvik requested a review from a team May 19, 2023 07:07
@print-Sathvik print-Sathvik requested a review from a team as a code owner May 19, 2023 07:07
@vercel
Copy link

vercel bot commented May 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 0:44am

@netlify
Copy link

netlify bot commented May 19, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a1f8307
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/646e06450702430007aebcf3
😎 Deploy Preview https://deploy-preview-5487--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad requested changes May 19, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You should also be replacing <Legacy____> components too with newer <____FormField> components as Legacy components indirectly use material ui.
  2. Also, when using FormField components, you need not use <FieldLabel> separately as it can be achieved with label prop present in all form field components.
  3. Link issues to your PR. Refer: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@print-Sathvik print-Sathvik closed this by deleting the head repository May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad requested changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
changes required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@print-Sathvik @rithviknishad