Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tooltip on occupancy chip in facility card #5539

Merged
merged 3 commits into from
May 26, 2023
Merged

Added tooltip on occupancy chip in facility card #5539

merged 3 commits into from
May 26, 2023

Conversation

Bhavik-ag
Copy link
Contributor

@Bhavik-ag Bhavik-ag commented May 26, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at cc2898e

Added a tooltip feature to the facility card component to explain the bed occupancy ratio. Modified FacilityCard.tsx and added some CSS classes.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at cc2898e

  • Add tooltip functionality to the facility card ratio element (link, link)

@Bhavik-ag Bhavik-ag requested a review from a team May 26, 2023 10:24
@Bhavik-ag Bhavik-ag requested a review from a team as a code owner May 26, 2023 10:24
@Bhavik-ag Bhavik-ag requested a review from bodhish May 26, 2023 10:24
@vercel
Copy link

vercel bot commented May 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 11:58am

@netlify
Copy link

netlify bot commented May 26, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9bf6a74
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64709ea017c2b100084dc4b8
😎 Deploy Preview https://deploy-preview-5539--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Bhavik-ag 🚀

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit a0894c5 into ohcnetwork:develop May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct the occupancy details in facility card
4 participants
@Bhavik-ag @nihal467 @rithviknishad @khavinshankar