Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons width bug fixed in mobile view of file section in patient consultation page #5548

Closed
wants to merge 1 commit into from

Conversation

lord2anil
Copy link

@lord2anil lord2anil commented May 26, 2023

buttons width bug fixed in the mobile view of file section in the patient consultation page

WHAT

In the file tab of patient consultation page, all the buttons are not in full width during responsive view
image

Proposed Changes

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at f370d3a

  • Make file upload, camera, and voice recording buttons fill the available width of the parent container for better layout and alignment (link, link, link, link)

@lord2anil lord2anil requested a review from a team May 26, 2023 19:24
@lord2anil lord2anil requested a review from a team as a code owner May 26, 2023 19:24
@lord2anil lord2anil requested a review from bodhish May 26, 2023 19:24
@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 7:25pm

@netlify
Copy link

netlify bot commented May 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f370d3a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6471075a491d81000893d645
😎 Deploy Preview https://deploy-preview-5548--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

@lord2anil
image

  • in the iPad mini dimension, the buttons are not properly responsive

image

  • Remove the extra width you added to the button
  • Keep the " camera " and " file choose "buttons towards the left and the " upload " button towards the right side in the normal view

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 5, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make buttons width consistent in mobile view of file section in patient consultation page
3 participants