Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed MUI Components from AddLocationCard #5558

Merged
merged 4 commits into from
May 30, 2023
Merged

Removed MUI Components from AddLocationCard #5558

merged 4 commits into from
May 30, 2023

Conversation

divyanshkhetan
Copy link
Contributor

@divyanshkhetan divyanshkhetan commented May 29, 2023 •
edited
Loading

Removed the Card and Card Content tags from the AddLocation.tsx file.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Screenshots:

Before After
Add Location Card Before Add Location Card After 2

@divyanshkhetan divyanshkhetan requested a review from a team May 29, 2023 07:35
@divyanshkhetan divyanshkhetan requested a review from a team as a code owner May 29, 2023 07:35
@vercel
Copy link

vercel bot commented May 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 9:20am

@netlify
Copy link

netlify bot commented May 29, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f19f1c8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6475bfc157bef7000813fe17
😎 Deploy Preview https://deploy-preview-5558--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad requested changes May 29, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, however you have not converted PageTitle to Page component yet.

Also ensure there are no paddings before the page component. this is to keep layout consistent.

@divyanshkhetan
Copy link
Contributor Author

@rithviknishad PTAL and let me know if any changes are needed.

@nihal467
Copy link
Member

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 4ab2a7a into ohcnetwork:develop May 30, 2023
@divyanshkhetan divyanshkhetan deleted the issue4944 branch May 31, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Facility/AddLocationForm.tsx:
4 participants
@divyanshkhetan @nihal467 @rithviknishad @khavinshankar