-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display selected facility name in the filter #5559
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @print-Sathvik
I assume you accidentally checked out the branch from your previous PR instead of develop?
Your previous PRs changes are present here.
You may create a new branch from develop instead of your old branch.
git checkout develop
git checkout -b "new-branch-name"
👋 Hi, @print-Sathvik, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
1 similar comment
👋 Hi, @print-Sathvik, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Yes @rithviknishad , I changed the branch now. Also fixed the same issue with Location Filter and created a new PR(5574) as this cannot be reopened. |
WHAT
Current facility was previously not being shown in the advanced filter even though the
?facility={{facility_id}}
is present in the query params. Made some changes inAssetFilter.tsx
to fix it(Ignore other 3 files, they are part of previous PR that's not merged)Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at ef527af
getPermittedFacility
action instead ofgetAnyFacility
action to restrict user access to facilities (link, link)max-w-3xl
class fromForm
component insrc/Components/Form/Form.tsx
to make form width consistent withAssetFilter
component (link)max-w-3xl
class toCreatePrescriptionForm
component insrc/Components/Medicine/CreatePrescriptionForm.tsx
to limit form width and improve readability and responsiveness (link)