Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display selected facility name in the filter #5559

Closed
wants to merge 3 commits into from

Conversation

print-Sathvik
Copy link
Contributor

@print-Sathvik print-Sathvik commented May 29, 2023

WHAT

Current facility was previously not being shown in the advanced filter even though the ?facility={{facility_id}} is present in the query params. Made some changes in AssetFilter.tsx to fix it(Ignore other 3 files, they are part of previous PR that's not merged)

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at ef527af

  • Use getPermittedFacility action instead of getAnyFacility action to restrict user access to facilities (link, link)
  • Remove max-w-3xl class from Form component in src/Components/Form/Form.tsx to make form width consistent with AssetFilter component (link)
  • Add max-w-3xl class to CreatePrescriptionForm component in src/Components/Medicine/CreatePrescriptionForm.tsx to limit form width and improve readability and responsiveness (link)

@print-Sathvik print-Sathvik requested a review from a team May 29, 2023 07:46
@print-Sathvik print-Sathvik requested a review from a team as a code owner May 29, 2023 07:46
@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 7:47am

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ef527af
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6474584e9062550008cbb7bb
😎 Deploy Preview https://deploy-preview-5559--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@print-Sathvik print-Sathvik changed the title Sathvik5470 Display selected facility name in the filter May 29, 2023
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @print-Sathvik
I assume you accidentally checked out the branch from your previous PR instead of develop?

Your previous PRs changes are present here.

You may create a new branch from develop instead of your old branch.

git checkout develop
git checkout -b "new-branch-name"

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 31, 2023
@github-actions
Copy link

👋 Hi, @print-Sathvik,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

1 similar comment
@github-actions
Copy link

👋 Hi, @print-Sathvik,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@print-Sathvik print-Sathvik deleted the Sathvik5470 branch May 31, 2023 15:43
@print-Sathvik
Copy link
Contributor Author

Yes @rithviknishad , I changed the branch now. Also fixed the same issue with Location Filter and created a new PR(5574) as this cannot be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected facility in asset filters not showing if navigated from Manage Facility -> View Assets
3 participants