Fixed pagination bug in FileUpload Component #5580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@patelaryan7751 check the cypress failing and fix it |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@patelaryan7751 is attempting to deploy a commit to the Coronasafe Team on Vercel. A member of the Team first needs to authorize it. |
|
LGTM |
khavinshankar
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 42c0118
This change improves the file upload component for patient files by adding sorting and pagination features for both archived and unarchived files. It also simplifies the state management and rendering logic by using separate variables and functions for each file category in
FileUpload.tsx.Proposed Changes
Fixed pagination bug in FileUpload Component made separate pagination for Archived Files and Unarchived Files tab
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 42c0118
uploadedFilesandtotalCountstate variables into two separate variables each, based on the archival status of the files, to support the sorting and pagination features of the file upload component (link, link)viewUploadaction to accept an additional parameter,is_archived, and fetch both archived and unarchived files from the backend using thearchivedFileDataandunarchievedFileDataobjects, and update the state with thesetuploadedArchievedFilesandsetuploadedUnarchievedFilesfunctions (link, link)src/Components/Patient/FileUpload.tsxto use the new state variables instead of filtering theuploadedFilesarray based on thesortFileStatevariable, to improve the performance and readability of the component (link)