Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Test - Create Consultation For a new patient #5603

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Jun 5, 2023

WHAT

🤖 Generated by Copilot at e1ed6b2

The pull request improves the end-to-end testing of the patient and consultation features by updating the test suite to reflect the latest UI changes and adding a new test case for consultation creation. It also adds a data-testid attribute to a button component to facilitate testing.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at e1ed6b2

  • Rename patient creation test suite and test case to include consultation (link, link)
  • Update patient creation test case to match new patient registration form fields (link, link, link)
  • Rename dashboard test case to clarify its purpose and scope (link)
  • Simplify edit test case to only change and verify patient name and URL (link)
  • Add new consultation test case to create and verify a consultation for an existing patient with a prescription medication (link)
  • Add data-testid attribute to ButtonV2 component for returning to patient dashboard (link)

@nihal467 nihal467 requested a review from a team June 5, 2023 10:56
@nihal467 nihal467 requested a review from a team as a code owner June 5, 2023 10:56
@nihal467 nihal467 requested a review from gigincg June 5, 2023 10:56
@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 7:11am

@netlify
Copy link

netlify bot commented Jun 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ef449b2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/647edbb2436a6c00082e8c4d
😎 Deploy Preview https://deploy-preview-5603--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member Author

nihal467 commented Jun 5, 2023

@khavinshankar can you review it and merge it

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nihal467 LGTM, just change the hardcoded waits

cypress/e2e/patient_spec/patient_crud.cy.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 864a9c0 into develop Jun 6, 2023
@khavinshankar khavinshankar deleted the Cypress-consultation branch June 6, 2023 07:16
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jun 6, 2023
@nihal467 nihal467 removed the cypress failed pull request with cypress test failure label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress Test : create a new consultation
2 participants