Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds SampleViewAdmin.tsx #5660

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Tailwinds SampleViewAdmin.tsx #5660

merged 1 commit into from
Jun 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 13, 2023

WHAT

🤖 Generated by Copilot at fa68d90

Refactored the sample view admin page to use the Page component for better layout and code quality.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at fa68d90

  • Replace PageTitle component with Page component, which includes title, breadcrumbs, and optional right component, to reduce code duplication and improve consistency (link, link, link, link)
  • Move export button to the right of the title using componentRight prop of Page component (link)
  • Update SampleViewAdmin component to use Page component as root element and pass relevant props (link, link)

@rithviknishad rithviknishad requested a review from a team June 13, 2023 16:01
@rithviknishad rithviknishad requested a review from a team as a code owner June 13, 2023 16:01
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 4:02pm

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fa68d90
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648892f789edd400088262ee
😎 Deploy Preview https://deploy-preview-5660--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added cypress failed pull request with cypress test failure cypress passed and removed cypress failed pull request with cypress test failure labels Jun 13, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 2e34d6e into develop Jun 21, 2023
@khavinshankar khavinshankar deleted the tailwind/4986 branch June 21, 2023 06:36
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Patient/SampleViewAdmin.tsx:
3 participants