Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other browser #5682

Closed
wants to merge 3 commits into from
Closed

Conversation

Yash12Bansal
Copy link

I had made the changes but forgot to make a pr as I was working on other issues. So, sorry for that delay
I have made all the changes and it now supports all major browsers. I have also untracked package-lock.json files
So please review and accept the pr

@Yash12Bansal Yash12Bansal requested a review from a team June 15, 2023 07:48
@Yash12Bansal Yash12Bansal requested a review from a team as a code owner June 15, 2023 07:48
@vercel
Copy link

vercel bot commented Jun 15, 2023

@Yash12Bansal is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0eeef6a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/648ac24d2f65570008dac424
😎 Deploy Preview https://deploy-preview-5682--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the previous PR also I've requested the changes saying that, do this for all browsers regardless of Firefox or not right?

@rithviknishad
Copy link
Member

Kindly link the issue in the PR with closing tags

@rithviknishad
Copy link
Member

Also update the PR title to something meaningful. "Other browser" doesn't make any sense

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 23, 2023
@gigincg
Copy link
Member

gigincg commented Jun 27, 2023

@Yash12Bansal Please update with a relavant PR Description

@github-actions github-actions bot removed the stale label Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 5, 2023
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Jul 13, 2023
@khavinshankar
Copy link
Member

@rithviknishad is this relevant?

@khavinshankar khavinshankar reopened this Jul 18, 2023
@rithviknishad
Copy link
Member

The issue related to this is #5611 however I'm unable to reproduce in firefox nor chrome. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants