Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place Vitals Card at full-width at the very first of consultation updates section #5728

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 20, 2023

WHAT

🤖 Generated by Copilot at fdb85e9

This pull request fixes a UI bug in the patient vitals monitor component that caused data overlap when scrolling. It adds a z-index and a background color to the div element that contains the non-waveform data in both HL7PatientVitalsMonitor.tsx and VentilatorPatientVitalsMonitor.tsx.

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at fdb85e9

  • Fix bug where waveform data overlaps non-waveform data in patient vitals monitor (link, link)

@rithviknishad rithviknishad requested a review from a team June 20, 2023 06:42
@rithviknishad rithviknishad requested a review from a team as a code owner June 20, 2023 06:42
@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2023 9:31am

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit dfc4126
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6492c33b55799e0007fb9bd7
😎 Deploy Preview https://deploy-preview-5728--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Jun 20, 2023
@github-actions github-actions bot added cypress failed pull request with cypress test failure and removed cypress passed labels Jun 20, 2023
@nihal467
Copy link
Member

LGTM but it is still not responsive in the mobile view

@khavinshankar khavinshankar merged commit b83325c into develop Jun 21, 2023
@khavinshankar khavinshankar deleted the move-logupdates-below-vitals branch June 21, 2023 09:40
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants