Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linting errors and add ventilator icon #5765

Merged
merged 11 commits into from
Jul 12, 2023
Merged

Fix linting errors and add ventilator icon #5765

merged 11 commits into from
Jul 12, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Jun 23, 2023 •
edited
Loading

Blocked: Merge #5793 before this

WHAT

🤖 Generated by Copilot at 86c34d3

No summary available (Limit exceeded: required to process 129354 tokens, but only 50000 are allowed per call)

Proposed Changes

  • Fix ts-lint and eslint errors
  • Add ventilator icon
    image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 86c34d3

No walkthrough available (Limit exceeded: required to process 129354 tokens, but only 50000 are allowed per call)

@Ashesh3 Ashesh3 requested a review from a team June 23, 2023 09:36
@Ashesh3 Ashesh3 requested a review from a team as a code owner June 23, 2023 09:36
@Ashesh3 Ashesh3 requested a review from mathew-alex June 23, 2023 09:36
@vercel
Copy link

vercel bot commented Jun 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 5:06am

@netlify
Copy link

netlify bot commented Jun 23, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7a546d1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64ae34915466b20008998789
😎 Deploy Preview https://deploy-preview-5765--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict labels Jun 23, 2023
@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jun 27, 2023
@nihal467
Copy link
Member

@Ashesh3
image

  • all the dropdown are messed up in the user creation form. fix it and re-check the QA of the PR

@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 28, 2023
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jun 28, 2023
@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Jun 28, 2023
@Ashesh3
Copy link
Member Author

Ashesh3 commented Jun 28, 2023

@Ashesh3 image

  • all the dropdown are messed up in the user creation form. fix it and re-check the QA of the PR

Fixed

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jun 30, 2023
@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467 nihal467 added the waiting for related PR a co-related detail PR is under construction label Jul 3, 2023
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Jul 6, 2023
@Ashesh3 Ashesh3 added merge conflict pull requests with merge conflict and removed blocked waiting for related PR a co-related detail PR is under construction merge conflict pull requests with merge conflict labels Jul 6, 2023
@github-actions github-actions bot added cypress failed pull request with cypress test failure and removed cypress passed labels Jul 6, 2023
@nihal467
Copy link
Member

LGTM, Cypress failure not related to this PR

@github-actions github-actions bot added cypress passed and removed cypress failed pull request with cypress test failure labels Jul 12, 2023
@khavinshankar khavinshankar merged commit 54b0f5f into develop Jul 12, 2023
@khavinshankar khavinshankar deleted the fix-linting-errors branch July 12, 2023 08:28
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Ashesh3 added a commit that referenced this pull request Jul 12, 2023
@Ashesh3
Fix linting errors and add ventilator icon (#5765)
a1f8af0 
* Fix linting errors and add ventilator icon

* fix bugs

* fix bug

* nullish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
cypress passed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashesh3 @nihal467 @khavinshankar