Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cypress Failure | Facility Creation | #5825

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Jul 3, 2023

WHAT

🤖 Generated by Copilot at 17537b2

Removed code that disabled browser cache in cypress/e2e/facility_spec/facility.cy.ts to improve test reliability and performance.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 17537b2

  • Remove code to disable browser cache using Chrome DevTools Protocol (link) as it was causing flaky tests and was not necessary for the functionality of the test suite

@nihal467 nihal467 requested a review from a team July 3, 2023 08:07
@nihal467 nihal467 requested a review from a team as a code owner July 3, 2023 08:07
@nihal467 nihal467 requested a review from bodhish July 3, 2023 08:07
@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 8:07am

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 17537b2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64a281a93b638d0008ca1a68
😎 Deploy Preview https://deploy-preview-5825--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added cypress failed pull request with cypress test failure cypress passed and removed cypress failed pull request with cypress test failure labels Jul 3, 2023
@khavinshankar khavinshankar merged commit 2cf8810 into develop Jul 3, 2023
@khavinshankar khavinshankar deleted the Fix-facility branch July 3, 2023 09:16
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants