Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command.ts modified for accepting dynamic token refresh in cypress #5864

Closed
wants to merge 4 commits into from

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Jul 12, 2023

WHAT

🤖 Generated by Copilot at a624294

This file enhances the testing commands for authentication and notification features by using local-cypress objects, simplifying the token handling, and cleaning up the code.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at a624294

  • Refactor the refreshApiLogin and loginByApi commands to use separate functions for fetching and updating the tokens (link)
  • Import the cy and Cypress objects from local-cypress and define the TOKEN_JSON_PATH constant (link)
  • Remove the force: true option from the click command in the verifyNotification command (link)
  • Remove the comment that describes the getAttached command (link)

@nihal467 nihal467 requested a review from a team July 12, 2023 09:23
@nihal467 nihal467 requested a review from a team as a code owner July 12, 2023 09:23
@vercel
Copy link

vercel bot commented Jul 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 2:51pm

@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5eddf3c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64aebdd5c892de000871ea70
😎 Deploy Preview https://deploy-preview-5864--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked cypress failed pull request with cypress test failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant