Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes in shifting form #5978

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Aug 1, 2023

…one number field

WHAT

🤖 Generated by Copilot at a385a06

This pull request enables the country selector for phone number inputs in various forms throughout the application. This improves the consistency and usability of the phone number input component, and fixes the issue #1729 of inconsistent phone number formats for different countries. The pull request modifies the PhoneNumberFormField component and its usage in several files, such as ShiftCreate.tsx, UserAdd.tsx, FacilityCreate.tsx, and ResourceCreate.tsx.

Proposed Changes

  • Fixes Shifting form #5943
  • Changed "Contact person at the current facility" to "Name of Contact person at the current facility"
  • Changed "Contact person phone" to "Contact person phone number"
  • Removed disableCountry prop from PhoneNumberFormField

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at a385a06

  • Remove the disableCountry prop from the PhoneNumberFormField component and enable the country selector for the phone number inputs in various forms (link, link, link, link, link, link, link). This change affects the FacilityCreate, ShiftCreate, ResourceCreate, and UserAdd components in the src/Components directory, and is intended to resolve the issue added result filter in SampleTest #1729.

@GokulramGHV GokulramGHV requested a review from a team August 1, 2023 12:53
@GokulramGHV GokulramGHV requested a review from a team as a code owner August 1, 2023 12:53
@vercel
Copy link

vercel bot commented Aug 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 2:25pm

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5fe1b1f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64c9158e998eb10008ea9d33
😎 Deploy Preview https://deploy-preview-5978--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Aug 2, 2023

LGTM

@khavinshankar khavinshankar merged commit cd3c367 into ohcnetwork:develop Aug 2, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shifting form
3 participants