Plausible: Redact IDs in goal urls and removed patient id from goal trigger props #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rithviknishad
changed the title
Ashesh3
approved these changes
Aug 14, 2023
github-actions
bot
added
the
cypress failed
Ashesh3
reviewed
Aug 14, 2023
Ashesh3
approved these changes
Aug 14, 2023
khavinshankar
approved these changes
Aug 14, 2023
khavinshankar
added
good to merge
and removed
needs review
cypress failed
|
@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at d6eb840
Refactored the code for sending pageview and custom events to Plausible with redacted URLs. Removed
patientIdfrom various components and actions that did not need it, simplifying the code and reducing API calls. Affected files includePlausible.tsx,ConsultationDetails.tsx,Feed.tsx,PatientHome.tsx, andHL7PatientVitalsMonitor.tsx.Proposed Changes
triggerGoal#6073manualextension back.@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at d6eb840
triggerPageViewtogetRedactedUrland change it to return a string instead of sending an event (link)useLocationChangeanduseEffecthooks to callplausibleinstead oftriggerPageView(link)plausiblefunction to wrap the globalplausiblevariable and add the redacted URL and other data to the event (link)patientIdproperty from various action payloads and component props (link, link, link, link, link, link, link, link, link)patientIdfromcreateConsultationandupdateConsultationactions inConsultationDetails.tsx(link, link)patientIdfromFeedcomponent props andgetConsultationFeed,createDailyRound, andcreateInvestigationactions inFeed.tsx(link, link, link, link, link)patientIdfromtriggerGoalandplausiblefunction calls inPatientHome.tsxandHL7PatientVitalsMonitor.tsx(link, link)