Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to use a stock in inventory #6115

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Aug 20, 2023

WHAT

🤖 Generated by Copilot at 0bc0424

Fix inventory form issues in AddInventoryForm.tsx. Ensure the isIncoming field uses the correct values and validates properly.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 0bc0424

  • Fix the validation of the isIncoming field in the inventory form to allow false values (link)
  • Change the options for the isIncoming field in the inventory form to use numeric values instead of boolean values to match the backend API (link)

@Pranshu1902 Pranshu1902 requested a review from a team August 20, 2023 15:06
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner August 20, 2023 15:06
@vercel
Copy link

vercel bot commented Aug 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 3:07pm

@netlify
Copy link

netlify bot commented Aug 20, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0bc0424
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64e22c10a9206d00070ddb80
😎 Deploy Preview https://deploy-preview-6115--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pranshu1902 Pranshu1902 added the P1 breaking issue or vital feature label Aug 21, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 0a06585 into ohcnetwork:develop Aug 23, 2023
27 of 28 checks passed
ShivamJhaa pushed a commit to ShivamJhaa/care_fe that referenced this pull request Aug 24, 2023
khavinshankar pushed a commit that referenced this pull request Sep 7, 2023
…t_crud.ts to POM approach (#5870)

* Added test for importing and configuring an asset

* Revert few changes

* nits

* Migrated to POM approach

* Migrated patient_crud to POM approach

* reverted some chnages

* FIx

* Merge conflicts

* Fixed test

* add responsiveness to virtual nursing assistant card (#6130)

* allow use stock as well (#6115)

* fixed responsive issue of 'Update Log' button in patient consultation page (#6113)

* fix multiple bed bug (#6111)

* Fixed typo in Date format in Asset management (#6105)

* Added padding to count block on patients page

* fixed date format in asset manage page

* show only items with no min value (#6103)

* check for id in response (#6100)

* Added Responsiveness to File upload (#6096)

* add responsiveness

* refactor

* remove overlap (#6094)

* fixed failing test

* Fix

* Fixed comments

* fix comments

* Fixed all comments

---------

Co-authored-by: Pranshu Aggarwal <70687348+Pranshu1902@users.noreply.github.com>
Co-authored-by: Gokulram A <gokulram2010418@ssn.edu.in>
Co-authored-by: Kshitij Verma <101321276+kshitijv256@users.noreply.github.com>
Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
khavinshankar pushed a commit that referenced this pull request Oct 20, 2023
* Added test for importing and configuring an asset

* Revert few changes

* nits

* Migrated to POM approach

* Migrated patient_crud to POM approach

* reverted some chnages

* FIx

* Merge conflicts

* Fixed test

* Added test for patient_test

* nits

* add responsiveness to virtual nursing assistant card (#6130)

* allow use stock as well (#6115)

* fixed responsive issue of 'Update Log' button in patient consultation page (#6113)

* fix multiple bed bug (#6111)

* Fixed typo in Date format in Asset management (#6105)

* Added padding to count block on patients page

* fixed date format in asset manage page

* show only items with no min value (#6103)

* check for id in response (#6100)

* Added Responsiveness to File upload (#6096)

* add responsiveness

* refactor

* remove overlap (#6094)

* fixed failing test

* Fix

* Fixed comments

* fix comments

* Fixed all comments

* Migrated test to new test suite

* Added upload file test

* fixed failing test

* Fix failing test

* Revert unwanted changes

* fixed conflict

* random failure fixed

* temporary fixed medicine selection

---------

Co-authored-by: Pranshu Aggarwal <70687348+Pranshu1902@users.noreply.github.com>
Co-authored-by: Gokulram A <gokulram2010418@ssn.edu.in>
Co-authored-by: Kshitij Verma <101321276+kshitijv256@users.noreply.github.com>
Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
Ashesh3 pushed a commit that referenced this pull request Oct 20, 2023
* Added test for importing and configuring an asset

* Revert few changes

* nits

* Migrated to POM approach

* Migrated patient_crud to POM approach

* reverted some chnages

* FIx

* Merge conflicts

* Fixed test

* Added test for patient_test

* nits

* add responsiveness to virtual nursing assistant card (#6130)

* allow use stock as well (#6115)

* fixed responsive issue of 'Update Log' button in patient consultation page (#6113)

* fix multiple bed bug (#6111)

* Fixed typo in Date format in Asset management (#6105)

* Added padding to count block on patients page

* fixed date format in asset manage page

* show only items with no min value (#6103)

* check for id in response (#6100)

* Added Responsiveness to File upload (#6096)

* add responsiveness

* refactor

* remove overlap (#6094)

* fixed failing test

* Fix

* Fixed comments

* fix comments

* Fixed all comments

* Migrated test to new test suite

* Added upload file test

* fixed failing test

* Fix failing test

* Revert unwanted changes

* fixed conflict

* random failure fixed

* temporary fixed medicine selection

---------

Co-authored-by: Pranshu Aggarwal <70687348+Pranshu1902@users.noreply.github.com>
Co-authored-by: Gokulram A <gokulram2010418@ssn.edu.in>
Co-authored-by: Kshitij Verma <101321276+kshitijv256@users.noreply.github.com>
Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to use a stock in inventory
4 participants