Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C-PAP / PSV selector in critical care #6148

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Aug 24, 2023

WHAT

🤖 Generated by Copilot at f6d3c11

Fixed a bug and simplified the logic for the psv checkbox in the CriticalCare__VentilatorParametersEditor__Invasive component. Changed the checked and onChange props to use and update the parentVentilatorMode state.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at f6d3c11

  • Fixed a bug where the psv checkbox would not reflect the correct value of the parent component's state by using the parentVentilatorMode state instead of the state.ventilator_mode state for the checked prop of the Checkbox component (link)
  • Simplified the logic for updating the parentVentilatorMode state when the psv checkbox is changed by setting it to UNKNOWN instead of using a callback function for the onChange prop of the Checkbox component (link)

@Ashesh3 Ashesh3 added needs testing P1 breaking issue or vital feature labels Aug 24, 2023
@Ashesh3 Ashesh3 requested a review from a team August 24, 2023 08:38
@Ashesh3 Ashesh3 requested a review from a team as a code owner August 24, 2023 08:38
@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 8:39am

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f6d3c11
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64e7171ec38b61000818aa8d
😎 Deploy Preview https://deploy-preview-6148--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Aug 24, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 8c988b3 into develop Aug 25, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the fix-ventilator-critical-care branch August 25, 2023 02:16
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Respiratory support (critical care log update)
3 participants