Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset import from excel files #6182

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix asset import from excel files #6182

merged 1 commit into from
Aug 30, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Aug 30, 2023

WHAT

🤖 Generated by Copilot at 620b760

Improved asset import modal and removed unused property from asset interface. The modal can now handle different file formats, show better feedback, and display the imported data. The note property was removed from AssetData as it was redundant.

Proposed Changes

  • Fixes import for assets from an Excel file

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 620b760

  • Add optional properties notes and last_serviced_on to the preview state to handle additional fields in the asset import file (link)
  • Rename last_serviced_on and note properties to last_service.serviced_on and last_service.note respectively to match the asset creation API (link)
  • Expand file type validation to allow JSON, Excel, and CSV files for asset import in AssetImportModal.tsx (link)
  • Add margin to the preview table in AssetImportModal.tsx for better spacing (link)
  • Remove unused note property from the AssetData interface in AssetTypes.tsx (link)

@Ashesh3 Ashesh3 requested a review from a team August 30, 2023 11:46
@Ashesh3 Ashesh3 requested a review from a team as a code owner August 30, 2023 11:46
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Aug 30, 2023 11:46am

@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 620b760
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64ef2c001d088f0007bdd44f
😎 Deploy Preview https://deploy-preview-6182--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Aug 30, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 1523cc0 into develop Aug 30, 2023
28 of 29 checks passed
@khavinshankar khavinshankar deleted the fix-asset-import branch August 30, 2023 12:24
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants