Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixed : Default filters on patients page loads #6189

Merged

Conversation

mustafaazad03
Copy link
Contributor

WHAT

Solved the bug for An empty filter for emergency phone numbers to be applied by default.

Proposed Changes

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@mustafaazad03 mustafaazad03 requested a review from a team August 31, 2023 02:06
@mustafaazad03 mustafaazad03 requested a review from a team as a code owner August 31, 2023 02:06
@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2023 1:45am

@netlify
Copy link

netlify bot commented Aug 31, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9b69999
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f53691e3d66800085ad46a
😎 Deploy Preview https://deploy-preview-6189--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on fixing it! However, is setting limit=null necessary?

useFilters's limit prop is for identifying the pagination limit when paginating, and is not a default value!

And hence causes to:
image

Rest all LGTM!

@rithviknishad
Copy link
Member

Btw, you can keep pushing to this current branch instead of always re-opening a new PR! The commits will be squashed and merged anyways once tested!

@mustafaazad03
Copy link
Contributor Author

Ok I will see thanks for pointing out 🙂.

src/Components/Patient/ManagePatients.tsx Outdated Show resolved Hide resolved
src/Components/Patient/ManagePatients.tsx Outdated Show resolved Hide resolved
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@mustafaazad03
Copy link
Contributor Author

Hi @rithviknishad, I update all suggested changes will you please check

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mustafaazad03! LGTM.

@nihal467
Copy link
Member

nihal467 commented Sep 5, 2023

LGTM

@khavinshankar khavinshankar merged commit 9d9bb5e into ohcnetwork:develop Sep 5, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patients List: Empty emergency phone number filter applied by default on mount
4 participants