ConsultationDetails.tsx split into seperate components. #6232

thtauhid · 2023-09-07T03:21:23Z

WHAT

`🤖 Generated by Copilot at b736565`

This pull request adds several new components to the ConsultationDetails folder that render different tabs for displaying various data and plots related to a consultation. The components use existing components from other folders and pass the appropriate props to them. The components also use the PageTitle component to show the name of each tab.

Proposed Changes

Fixes Code Refactor: ConsultationDetails.tsx #5830

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

HOW

`🤖 Generated by Copilot at b736565`

Add new components to render different tabs for a consultation (link, link, link, link, link, link, link, link, link, link, link, link)

vercel · 2023-09-07T03:21:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 8, 2023 0:30am

netlify · 2023-09-07T03:21:30Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`5456fad`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/64fb13a7314bd30008b9cd29
😎 Deploy Preview	https://deploy-preview-6232--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad

Nice Work! LGTM.

* Fix fullscreen button for IOS * Fix fullscreen

github-actions · 2023-09-07T09:49:07Z

👋 Hi, @thtauhid,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

…velop

thtauhid · 2023-09-07T11:21:27Z

Had conflict of 3 lines. I've updated the lines.

…t_crud.ts to POM approach (ohcnetwork#5870) * Added test for importing and configuring an asset * Revert few changes * nits * Migrated to POM approach * Migrated patient_crud to POM approach * reverted some chnages * FIx * Merge conflicts * Fixed test * add responsiveness to virtual nursing assistant card (ohcnetwork#6130) * allow use stock as well (ohcnetwork#6115) * fixed responsive issue of 'Update Log' button in patient consultation page (ohcnetwork#6113) * fix multiple bed bug (ohcnetwork#6111) * Fixed typo in Date format in Asset management (ohcnetwork#6105) * Added padding to count block on patients page * fixed date format in asset manage page * show only items with no min value (ohcnetwork#6103) * check for id in response (ohcnetwork#6100) * Added Responsiveness to File upload (ohcnetwork#6096) * add responsiveness * refactor * remove overlap (ohcnetwork#6094) * fixed failing test * Fix * Fixed comments * fix comments * Fixed all comments --------- Co-authored-by: Pranshu Aggarwal <70687348+Pranshu1902@users.noreply.github.com> Co-authored-by: Gokulram A <gokulram2010418@ssn.edu.in> Co-authored-by: Kshitij Verma <101321276+kshitijv256@users.noreply.github.com> Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>

…hcnetwork#6106) * lints * Added test for resource and migrated it to POM * trying a fix * nits * backend change * Reverted useless changes * fix test * Fixed failing test * Added api verification * Diagnosis: Adds field Principal Diagnosis (ohcnetwork#6218) * adds field principle diagnosis * show in consultation details * fix typo * fix cypress * try adding wait * fix tests * open pdf file preview in new tab (ohcnetwork#6226) * Changed weekly to average weekly for working hours (ohcnetwork#6228) * Added padding to count block on patients page * fixed date format in asset manage page * Merged configure facility and configure health facility in one page * removed commented code * changed weekly to average weekly for working hours * Resolved comments --------- Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com> Co-authored-by: Rithvik Nishad <mail@rithviknishad.dev> Co-authored-by: Ashesh <3626859+Ashesh3@users.noreply.github.com> Co-authored-by: Kshitij Verma <101321276+kshitijv256@users.noreply.github.com>

) * Consultation: Verified By Doctor as Dropdown * filter by home_facility instead * fixes ohcnetwork#6213 * fix cypress * fix cypress * fix more cypressss * fix moreeeee * fix inventory * fix inventory

github-actions · 2023-09-07T17:19:01Z

👋 Hi, @thtauhid,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

)

* fix cypress :/ * Update cypress/pageobject/Facility/FacilityCreation.ts * fix double click --------- Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>

…/care_fe into develop

thtauhid · 2023-09-08T12:35:47Z

I should have removed {consultationData.verified_by} in commit afa08f3. But, removed it in 5456fad

Conflicts have been resolved.

Thanks.

rithviknishad

There are a lot of unnecessary changes now in this PR.

You'll have to rebase your original changes correctly.

rithviknishad · 2023-09-08T12:39:46Z

Let's try to get this merged first on Monday once the necessary changes are made.
This will always keep catching conflicts every day.

rithviknishad · 2023-09-08T12:39:55Z

@khavinshankar @nihal467

thtauhid · 2023-09-11T04:46:49Z

Hello,
I've created a new PR #6258 as this PR is a bit messy and I was having some issues rebasing it.
I hope it doesn't create much of a problem.

Thank you for understanding.

Should I close this PR?

github-actions · 2023-09-11T08:28:10Z

👋 Hi, @thtauhid,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

khavinshankar · 2023-09-11T08:28:47Z

@thtauhid is this a duplicate PR of #6258,

I'm closing this PR, If this is relevant, feel free to reopen it.

ConsultationDetails.tsx split into seperate components.

b736565

thtauhid requested a review from a team September 7, 2023 03:21

thtauhid requested a review from a team as a code owner September 7, 2023 03:21

thtauhid requested a review from vigneshhari September 7, 2023 03:21

vercel bot temporarily deployed to Preview September 7, 2023 03:22 Inactive

rithviknishad approved these changes Sep 7, 2023

View reviewed changes

rithviknishad added the needs testing label Sep 7, 2023

Fix fullscreen button for IOS (ohcnetwork#6225)

fe36bd0

* Fix fullscreen button for IOS * Fix fullscreen

github-actions bot added the merge conflict pull requests with merge conflict label Sep 7, 2023

thtauhid added 2 commits September 7, 2023 16:40

ConsultationDetails.tsx split into seperate components.

51f29d7

Merge branch 'develop' of https://github.com/thtauhid/care_fe into de…

dcf5756

…velop

vercel bot temporarily deployed to Preview September 7, 2023 11:18 Inactive

rithviknishad removed the merge conflict pull requests with merge conflict label Sep 7, 2023

ShivamJhaa and others added 3 commits September 7, 2023 17:43

User (Doctor) Autocomplete for Consultation Verified By (ohcnetwork#6194

0c2be8b

) * Consultation: Verified By Doctor as Dropdown * filter by home_facility instead * fixes ohcnetwork#6213 * fix cypress * fix cypress * fix more cypressss * fix moreeeee * fix inventory * fix inventory

github-actions bot added the merge conflict pull requests with merge conflict label Sep 7, 2023

khavinshankar and others added 6 commits September 8, 2023 07:28

Temporarily expose abdm health facility config directly (ohcnetwork#6197

4519b08

)

cypress: fix inventory management (ohcnetwork#6245)

8bcf91d

* fix cypress :/ * Update cypress/pageobject/Facility/FacilityCreation.ts * fix double click --------- Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>

ConsultationDetails.tsx split into seperate components.

88e6266

ConsultationDetails.tsx split into seperate components.

e2e02e5

Updated against commit 0c2be8b

afa08f3

Merge branches 'develop' and 'develop' of https://github.com/thtauhid…

5456fad

…/care_fe into develop

vercel bot temporarily deployed to Preview September 8, 2023 12:30 Inactive

rithviknishad requested changes Sep 8, 2023

View reviewed changes

rithviknishad added changes required and removed merge conflict pull requests with merge conflict labels Sep 8, 2023

github-actions bot added the merge conflict pull requests with merge conflict label Sep 11, 2023

khavinshankar closed this Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ConsultationDetails.tsx split into seperate components. #6232

ConsultationDetails.tsx split into seperate components. #6232

thtauhid commented Sep 7, 2023 •

edited by ghost

Loading

vercel bot commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

rithviknishad left a comment

github-actions bot commented Sep 7, 2023

thtauhid commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

thtauhid commented Sep 8, 2023

rithviknishad left a comment

rithviknishad commented Sep 8, 2023

rithviknishad commented Sep 8, 2023

thtauhid commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

khavinshankar commented Sep 11, 2023 •

edited

Loading

ConsultationDetails.tsx split into seperate components. #6232

ConsultationDetails.tsx split into seperate components. #6232

Conversation

thtauhid commented Sep 7, 2023 • edited by ghost Loading

WHAT

🤖 Generated by Copilot at b736565

Proposed Changes

Merge Checklist

HOW

🤖 Generated by Copilot at b736565

vercel bot commented Sep 7, 2023 • edited Loading

netlify bot commented Sep 7, 2023 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

rithviknishad left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 7, 2023

thtauhid commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

thtauhid commented Sep 8, 2023

rithviknishad left a comment

Choose a reason for hiding this comment

rithviknishad commented Sep 8, 2023

rithviknishad commented Sep 8, 2023

thtauhid commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

khavinshankar commented Sep 11, 2023 • edited Loading

thtauhid commented Sep 7, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at b736565`

`🤖 Generated by Copilot at b736565`

vercel bot commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

khavinshankar commented Sep 11, 2023 •

edited

Loading