Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show camera feed only for admin and doctor #6453

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 16, 2023

WHAT

🤖 Generated by Copilot at e13495c

The pull request adds more checks and conditions for rendering the configure button and the feed tab for ONVIF assets. These changes are meant to improve the security and usability of the asset management and consultation features.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at e13495c

  • Restrict access to asset configuration page for ONVIF assets (link)
  • Hide feed tab for discharged or non-admitted consultations (link)

@Ashesh3 Ashesh3 requested a review from a team October 16, 2023 04:42
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 16, 2023 04:42
@Ashesh3 Ashesh3 requested a review from bodhish October 16, 2023 04:42
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 587f898
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6532304ca7eb93000805b506
😎 Deploy Preview https://deploy-preview-6453--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:47am

@cypress
Copy link

cypress bot commented Oct 16, 2023

Passing run #1451 ↗︎

0 85 0 0 Flakiness 0

Details:

Show camera feed only for admin and doctor
Project: CARE Commit: 587f898f89
Status: Passed Duration: 03:04 💡
Started: Oct 20, 2023 7:53 AM Ended: Oct 20, 2023 7:56 AM

Review all test suite changes for PR #6453 ↗︎

@nihal467
Copy link
Member

@Ashesh3
image

the vital configure button is missing for district admin users

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 17, 2023

@Ashesh3 image

the vital configure button is missing for district admin users

Fixed.

DistrictAdmin / Doctor

image
image

Volunteer

image
image

@nihal467
Copy link
Member

@Ashesh3
image

  • For non-asset class assets, this PR is showing the configuration button, which shouldn't be shown

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 20, 2023

@Ashesh3 image

  • For non-asset class assets, this PR is showing the configuration button, which shouldn't be shown

fixed now

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b499b90 into develop Oct 25, 2023
55 checks passed
@khavinshankar khavinshankar deleted the issue-6430 branch October 25, 2023 14:12
@github-actions
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show camera feed ONLY to "Doctor", "District Admin" and "State Admin"
3 participants