Remove redundant facility selection pop-up for single facility users #6535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -477,6 +479,8 @@ export const PatientManager = () => { | |||
| [fetchFacilityBadgeName, fetchLocationBadgeName] | |||
| ); | |||
|
|
|||
| const { data: permittedData } = useQuery(routes.getPermittedFacilities, {}); | |||
There was a problem hiding this comment.
variable name permittedData doesn't make sense right?
Suggested change
| const { data: permittedData } = useQuery(routes.getPermittedFacilities, {}); | |
| const { data: permittedFacilities } = useQuery(routes.getPermittedFacilities, {}); |
rithviknishad
approved these changes
Nov 3, 2023
|
LGTM |
khavinshankar
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 05d165a
Added
useQueryto fetch user permissions and facilities inManagePatients.tsx. Added response type togetPermittedFacilitiesroute inapi.tsx.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 05d165a
useQueryhook androutesobject to fetch and access API endpoints (link)permittedDatavariable to store the response fromgetPermittedFacilitiesendpoint (link)onClickhandler foradd-patient-detailsbutton to check user's facility permission and navigate accordingly (link)TResproperty togetPermittedFacilitiesroute definition to specify the expected response type (link)