Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh administrations upon archive #6586

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 10, 2023

WHAT

🤖 Generated by Copilot at f0a888b

Added a new feature to archive medicine administration events in the PrescriptionTimeline component and refetch the data in the parent and child components. This improves the data consistency and user experience of the medicine administration sheet. Modified the files AdministrationEventCell.tsx, AdministrationTableRow.tsx, and PrescrpitionTimeline.tsx to implement this feature.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at f0a888b

  • Add refetch prop to AdministrationEventCell component to allow refetching data from parent component (link, link, link)
  • Pass refetch function from useQuery hook to AdministrationEventCell component in AdministrationTableRow component (link, link)
  • Add optional onRefetch prop to PrescriptionTimeline component to trigger refetching data from parent component (link, link)
  • Call both onRefetch and refetch functions in onArchived prop of PrescriptionTimelineEvent component to update data when an event is archived (link)

@rithviknishad rithviknishad requested a review from a team November 10, 2023 14:37
@rithviknishad rithviknishad requested a review from a team as a code owner November 10, 2023 14:37
Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 2:37pm

Copy link

netlify bot commented Nov 10, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f0a888b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654e402aa5cffc0009d1e86a
😎 Deploy Preview https://deploy-preview-6586--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 10, 2023

Passing run #1566 ↗︎

0 85 0 0 Flakiness 0

Details:

refresh administrations upon archive
Project: CARE Commit: f0a888bdc3
Status: Passed Duration: 02:36 💡
Started: Nov 10, 2023 2:40 PM Ended: Nov 10, 2023 2:43 PM

Review all test suite changes for PR #6586 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 5b9c618 into develop Nov 10, 2023
60 of 63 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix-6585 branch November 10, 2023 15:05
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Archive Medicine reflection need to be changed
3 participants