Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No close button once you open the discontinued prescriptions #6614

Merged
merged 7 commits into from
Nov 21, 2023
Merged

No close button once you open the discontinued prescriptions #6614

merged 7 commits into from
Nov 21, 2023

Conversation

AshrafMd-1
Copy link
Contributor

@AshrafMd-1 AshrafMd-1 commented Nov 15, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at c1cdaf4

This pull request improves the performance and usability of the MedicineAdministrationSheet component, which displays the prescriptions and doses for a patient. It allows the user to filter the discontinued prescriptions and to fetch more data on demand. It also refines the appearance and behavior of the scroll and button components.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at c1cdaf4

  • Optimize data fetching for discontinued prescriptions by adding a limit parameter that depends on the showDiscontinued state (link)
    • Wrapping the ScrollOverlay inside a styled div and moving the ButtonV2 outside it (link)
    • Adding a loading state and a toggle logic for the ButtonV2 to control the showDiscontinued state (link)

@AshrafMd-1 AshrafMd-1 requested a review from a team November 15, 2023 08:39
@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner November 15, 2023 08:39
@vercel Vercel
Copy link

vercel bot commented Nov 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 2:23pm

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 700453c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655625c316832100088ccacb
😎 Deploy Preview https://deploy-preview-6614--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad once can u review it

@nihal467
Copy link
Member

lgtm

@khavinshankar khavinshankar merged commit 3a77798 into ohcnetwork:develop Nov 21, 2023
36 checks passed
@AshrafMd-1 AshrafMd-1 deleted the Fix-#6599 branch November 21, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consultation Medicine Tab: No close button once you open the discontinued prescriptions.
4 participants
@AshrafMd-1 @nihal467 @rithviknishad @khavinshankar