Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed padding in "Reviewed before" chip in Consultation Dashboard #6647

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

AshrafMd-1
Copy link
Contributor

@AshrafMd-1 AshrafMd-1 commented Nov 15, 2023

WHAT

🤖[deprecated] Generated by Copilot at 89a62b6

Refactored the padding of the patient info card component to fix a UI issue. Modified the className attribute in src/Components/Patient/PatientInfoCard.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 89a62b6

  • Move the p-1 class to the common part of the className for the div that shows the patient review time indicator, to improve the alignment and appearance (link)

@AshrafMd-1 AshrafMd-1 requested a review from a team November 15, 2023 18:17
@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner November 15, 2023 18:17
Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 2:24pm

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b90d6a5
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655625df0004930007291adb
😎 Deploy Preview https://deploy-preview-6647--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to use classNames utility in these places next time

@nihal467
Copy link
Member

LGTM

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshrafMd-1 moving forward use classNames util for multiple or conditional classes

@khavinshankar khavinshankar merged commit f4f7917 into ohcnetwork:develop Nov 22, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Reviewed before" chip in Consultation Dashboard has no padding
4 participants