Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay before live feed reconnect #6655

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Add delay before live feed reconnect #6655

merged 4 commits into from
Nov 16, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Nov 16, 2023

WHAT

🤖[deprecated] Generated by Copilot at b5bf116

The pull request changes the polling intervals of the Feed and LiveFeed components in src/Components/Facility/Consultations to reduce the number of API requests and potential errors.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖[deprecated] Generated by Copilot at b5bf116

  • Increase the delay for polling the API for camera and live feed status to reduce unnecessary requests or errors (link, link)

@Ashesh3 Ashesh3 requested a review from a team November 16, 2023 11:03
@Ashesh3 Ashesh3 requested a review from a team as a code owner November 16, 2023 11:03
@Ashesh3 Ashesh3 requested a review from gigincg November 16, 2023 11:03
Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 11:43am

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f571281
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655600545630cf0008ae147b
😎 Deploy Preview https://deploy-preview-6655--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 16, 2023

Passing run #1585 ↗︎

0 85 0 0 Flakiness 0

Details:

Add delay before live feed reconnect
Project: CARE Commit: 001278b8b0
Status: Passed Duration: 02:50 💡
Started: Nov 16, 2023 11:16 AM Ended: Nov 16, 2023 11:19 AM

Review all test suite changes for PR #6655 ↗︎

@nihal467 nihal467 removed the tested label Nov 16, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 43d08e1 into develop Nov 16, 2023
23 of 27 checks passed
@khavinshankar khavinshankar deleted the cam-recon-delay branch November 16, 2023 11:45
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@cypress cypress bot mentioned this pull request Nov 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants