Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide location filter unless facility is selected #6682

Closed
wants to merge 3 commits into from
Closed

Hide location filter unless facility is selected #6682

wants to merge 3 commits into from

Conversation

ayush-seth
Copy link

@ayush-seth ayush-seth commented Nov 21, 2023

WHAT

🤖[deprecated] Generated by Copilot at 19a3d9f

This pull request contains several improvements to the code quality, performance, and user interface of some components in the care_fe frontend. It reorganizes imports, simplifies logic, avoids unnecessary rendering, refactors components, and changes layout and styling. It also fixes a minor type issue in the LocationSelect component.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 19a3d9f

  • Make errors prop optional in LocationSelectProps interface (link)
  • Reorder and group import statements alphabetically and by type in FacilityUsers.tsx, FormField.tsx, and PatientFilter.tsx (link, link, link)
  • Remove unused showDelete function in FacilityUsers.tsx (link)
  • Simplify condition for showing delete button for facility users in FacilityUsers.tsx to only allow state admins (link)
  • Wrap FieldErrorText component in conditional rendering in FormField.tsx to avoid unnecessary rendering (link)
  • Add AutoCompleteAsync and SelectMenuV2 components to import statements in PatientFilter.tsx to use them in the filter component (link)
  • Remove unused imports from PatientFilter.tsx to reduce clutter and improve readability (link)
  • Replace div elements with grid class with section elements with space-y-4 class in PatientFilter.tsx to improve semantics and spacing (link, link)
  • Wrap LocationSelect component in conditional rendering in PatientFilter.tsx to only show it when facility filter is selected (link)
  • Remove flex-none class from div elements containing LSG body and district filters in PatientFilter.tsx to prevent shrinking in smaller screens (link, link)

@ayush-seth ayush-seth requested a review from a team November 21, 2023 10:10
@ayush-seth ayush-seth requested a review from a team as a code owner November 21, 2023 10:10
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 10:11am

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 19a3d9f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655c820bde8db00008a76962
😎 Deploy Preview https://deploy-preview-6682--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant