Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "ICU Admission Date" only for Internal Transfer #6729

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 27, 2023

WHAT

🤖[deprecated] Generated by Copilot at b25d02c

Fix icu_admission_date bug in ConsultationForm. Make the field depend on route_to_facility being 30 to avoid errors with non-ICU options.

Proposed Changes

  • Show "ICU Admission Date" only for Internal Transfer

cc: @aparnacoronasafe

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at b25d02c

  • Prevent sending icu_admission_date value to the backend unless route_to_facility is 30 (link)
  • Hide icu_admission_date field from the user interface unless route_to_facility is 30 (link)

@rithviknishad rithviknishad requested a review from a team as a code owner November 27, 2023 12:13
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9769199
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65648894dbcb720008d2c5a3
😎 Deploy Preview https://deploy-preview-6729--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 0:17am

@rithviknishad rithviknishad added urgent needs testing P1 breaking issue or vital feature labels Nov 27, 2023
Copy link

cypress bot commented Nov 27, 2023

Passing run #1633 ↗︎

0 85 0 0 Flakiness 0

Details:

Show "ICU Admission Date" only for Internal Transfer
Project: CARE Commit: 97691995ce
Status: Passed Duration: 02:58 💡
Started: Nov 27, 2023 12:20 PM Ended: Nov 27, 2023 12:23 PM

Review all test suite changes for PR #6729 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 13fd680 into develop Nov 27, 2023
57 of 59 checks passed
@khavinshankar khavinshankar deleted the show-icu-admission-date-for-internal-transfer branch November 27, 2023 12:45
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants