Refactor user delete permissions to allow StateAdmin and DistrictAdmin #6781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #1662 ↗︎
Details:
Review all test suite changes for PR #6781 ↗︎ |
|||||||||||||||
Ashesh3
changed the title
|
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
LGTM |
khavinshankar
approved these changes
Dec 13, 2023
|
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend PR: coronasafe/care#1738
WHAT
🤖[deprecated] Generated by Copilot at 6ab927b
This pull request proposes changes to the way user deletion privileges are granted. Previously, it was based on the code which is directly visible in the user module file, but now it has been moved to a utility function.
In the
FacilityUsers.tsxandManageUsers.tsxfiles, the validation for user deletion access was directly placed within the component. However, to ensure cleaner code and avoid duplication, the logic has been moved to theutils.tsfile, inside a new function calledshowUserDelete. As per the function logic, only users who areStateAdminsfrom the same state as the target user orDistrictAdminsfrom the same district can delete users.This pull request hence not only enhances the readability and maintainability of our code but also successfully implements the needed feature of granting user deletion privileges to district admin and above.
Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖[deprecated] Generated by Copilot at 6ab927b
No walkthrough available (Limit exceeded: required to process 57580 tokens, but only 50000 are allowed per call)