Modified Administer medicine card to make it responsive #6784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@rithviknishad Please review it. |
rithviknishad
requested changes
Dec 6, 2023
There was a problem hiding this comment.
3 things:
- You've modified PrescriptionsDetailCard itself. This breaks the existing UI in other places.
- You should ideally be expanding the width of the Slideover component itself of the Bulk Administer, instead of changing the reusable component.
- You should discard the package-lock changes from this PR.
|
@rithviknishad Understood the instructions and I will proceed further more carefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the col span of Route and dosage label boxes and the sizing of medicine card. It's looking much responsive now.
Please review my changes.