Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance existing Cypress Test | Update existing facility | Facility Tab #6792

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Dec 4, 2023

WHAT

🤖[deprecated] Generated by Copilot at 57796b4

Improved the testing of the update facility feature in facility_spec/facility_creation.cy.ts by adding a new test case and removing an old one. Refactored the test data into constants for better readability and maintainability.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 57796b4

  • Add new test case for updating the existing facility (link)
  • Remove old and redundant test case for updating the existing facility (link)
  • Add new constants for testing the update facility feature (link)

@nihal467 nihal467 requested a review from a team as a code owner December 4, 2023 14:56
Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 6:04pm

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b2a83af
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/656e1473abaacf0008bfd1ee
😎 Deploy Preview https://deploy-preview-6792--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 4, 2023

Passing run #1680 ↗︎

0 90 0 0 Flakiness 0

Details:

Enhance existing Cypress Test | Update existing facility | Facility Tab
Project: CARE Commit: b2a83af58e
Status: Passed Duration: 02:42 💡
Started: Dec 4, 2023 6:07 PM Ended: Dec 4, 2023 6:09 PM

Review all test suite changes for PR #6792 ↗︎

@khavinshankar khavinshankar merged commit 9504655 into develop Dec 5, 2023
60 checks passed
@khavinshankar khavinshankar deleted the test-facility-update branch December 5, 2023 06:13
Copy link

github-actions bot commented Dec 5, 2023

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants