Disable submit button in round type normal if no value selected #6793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
the above patient have previous record, i haven't copied any record, i didn't filled any fields from physical examination info till rhythm description, still the save button is active, it is expected to be disabled if no data was entered in any of the fields |
Pranshu1902
force-pushed
the
issue#6787
branch
from
f3c1ec2
to
eb79485
Compare
|
@nihal467 Bug resolved |
rithviknishad
approved these changes
Dec 7, 2023
|
@Pranshu1902 @rithviknishad marking it for discussion as now in critical care, the above fields a mandatory thing to fill any of the field, need to get a final confirmation from @gigincg |
|
@nihal467 @Pranshu1902 as discussed,
|
rithviknishad
added
changes required
and removed
needs testing
discussion required
labels
rithviknishad
approved these changes
Dec 12, 2023
|
@nihal467 the form now isn't disabled for |
|
LGTM |
khavinshankar
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖[deprecated] Generated by Copilot at f3c1ec2
Enable different rounds types and form validation for daily rounds. Refactor
Submitcomponent inDailyRounds.tsx.Proposed Changes
Disable submit button in round type normal if no value is modified in the form for at least any 1 field
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖[deprecated] Generated by Copilot at f3c1ec2
disabledstate to control the submit button for daily rounds form (link)disabledstate and therounds_typevalue to theSubmitcomponent as props (link)Submitcomponent when the rounds type is "NORMAL" and the form is not filled (link)DailyRounds.tsx(link)