Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve page scroll resets in consultations tabs. #6825

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

AshrafMd-1
Copy link
Contributor

@AshrafMd-1 AshrafMd-1 commented Dec 8, 2023

WHAT

🤖[deprecated] Generated by Copilot at bdb8057

Fix UI bug in consultation details tabs. Add a div element with a min-h-screen class to ensure the tab content fills the screen height in src/Components/Facility/ConsultationDetails/index.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at bdb8057

  • Add a div element with a min-h-screen class to fix a UI bug in the tab content height (link)

@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner December 8, 2023 14:15
Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 3:18pm

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 66e6bae
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65787977623b6500082dbfec
😎 Deploy Preview https://deploy-preview-6825--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad once can u check

@nihal467
Copy link
Member

image

@AshrafMd-1 the page is getting unwanted white space under the PRN prescriptions

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad can you check the tabs once

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit e857d03 into ohcnetwork:develop Dec 13, 2023
27 of 36 checks passed
@AshrafMd-1 AshrafMd-1 deleted the Fix-#6765 branch December 13, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page scroll resets to top when switching to medicines tab
4 participants