Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Timeline UI for Bed Activity #6901

Merged
merged 48 commits into from
Apr 24, 2024

Conversation

thedevildude
Copy link
Contributor

@thedevildude thedevildude commented Dec 24, 2023

Proposed Changes

What's Changed?
image
Before:
Bed Timeline Before

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@thedevildude thedevildude requested a review from a team as a code owner December 24, 2023 09:35
Copy link

vercel bot commented Dec 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 1:56pm

Copy link

netlify bot commented Dec 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b4afe28
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6628a1823615d9000892a769
😎 Deploy Preview https://deploy-preview-6901--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice attempt, but couple of things:

  1. It'd be nice to have the screenshot of the changes always attached if it's a UI change.

  2. The folder name "BedAdministration" does not make sense.

  3. The UI could be improved, like the "IN USE" chip seems to be relatively bigger than the surrounding elements. This can be made small.

  4. The first element does not seem to have a connecting line to the second element.

  5. The last element seems to have an unnecessary connecting line drawn to a no element existing beyond it. This can be removed.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently showing time in two places which is redundant.

Also can we improve the wording to something like this instead (just suggesting, feel free to add your creativity)

- Transferred to <b>{bed_name} in {location_name}</b>   (relative time)
- Transferred to <b>{bed_name} in {location_name}</b>   (relative time)
- Occupied <b>{bed_name} in {location_name}</b>         (relative time)

@thedevildude
Copy link
Contributor Author

We are currently showing time in two places which is redundant.

Also can we improve the wording to something like this instead (just suggesting, feel free to add your creativity)

- Transferred to <b>{bed_name} in {location_name}</b>   (relative time)
- Transferred to <b>{bed_name} in {location_name}</b>   (relative time)
- Occupied <b>{bed_name} in {location_name}</b>         (relative time)

I'll be working on some mockups and share them on channel

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 13, 2024
@rithviknishad rithviknishad added needs testing and removed changes required Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict labels Apr 4, 2024
@nihal467
Copy link
Member

@thedevildude fix the lint

@thedevildude
Copy link
Contributor Author

@nihal467 not sure if the Lint workflow is providing correct results. Locally the said files doesn't have any linting errors.

@rithviknishad
Copy link
Member

rithviknishad commented Apr 18, 2024

try re-installing the packages in your local. Recently the version has changed and seems to be causing similar issues for couple of contributors. Upgrading locally fixes it

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 90dc755 into ohcnetwork:develop Apr 24, 2024
27 of 29 checks passed
Copy link

@thedevildude Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline style view for Bed Allocation History
5 participants