Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect loading state when login form is invalid (no credentials provided) #7011

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 5:51am

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a6621da
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65a0d32b37d3a200081fce00
😎 Deploy Preview https://deploy-preview-7011--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jan 12, 2024

Passing run #1871 ↗︎

0 98 0 0 Flakiness 0

Details:

Fixes incorrect loading state when login form is invalid (no credentials provide...
Project: CARE Commit: a6621da78b
Status: Passed Duration: 02:19 💡
Started: Jan 12, 2024 5:54 AM Ended: Jan 12, 2024 5:56 AM

Review all test suite changes for PR #7011 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit dfe9923 into develop Jan 12, 2024
61 checks passed
@khavinshankar khavinshankar deleted the fix-empty-creds-login-loading-state branch January 12, 2024 06:29
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login-in button going to infinite loading post clicking it
3 participants