Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ongoing vists page #45

Closed
agneym opened this issue Jul 17, 2020 · 6 comments · Fixed by #58
Closed

Ongoing vists page #45

agneym opened this issue Jul 17, 2020 · 6 comments · Fixed by #58
Labels
ui
Milestone
MVP

Comments

@agneym
Copy link
Contributor

agneym commented Jul 17, 2020

  • Show merchant name and address next to ongoing visits list
@agneym agneym added the ui label Jul 17, 2020
@agneym agneym added this to the MVP milestone Jul 17, 2020
@amaljosea
Copy link
Contributor

@agneym Checking this

@agneym
Copy link
Contributor Author

agneym commented Jul 18, 2020

@amaljosea Checkout the doc for the concerned API. You would need latest develop if you have issues signing in

@amaljosea
Copy link
Contributor

amaljosea commented Jul 18, 2020 •
edited
Loading

@agneym Is this api is working for you?
http://localhost:3000/api/v1/visits/ongoing

Screenshot 2020-07-18 at 11 59 28 AM

@amaljosea
Copy link
Contributor

Seems like
Apis /api/v1/visits/ongoing and /api/v1/visits not working for some scenarios.

user has no visit - api is working
user has 1 visit - api is working
user has 2 visit - api is not working
user has more than 2 visits - api is not working

@agneym
Copy link
Contributor Author

agneym commented Jul 18, 2020

cc @unnitallman

@amaljosea amaljosea mentioned this issue Jul 18, 2020
Closed
@unnitallman
Copy link
Contributor

Seems like
Apis /api/v1/visits/ongoing and /api/v1/visits not working for some scenarios.

user has no visit - api is working
user has 1 visit - api is working
user has 2 visit - api is not working
user has more than 2 visits - api is not working

#50 (comment)

@amaljosea amaljosea mentioned this issue Jul 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

Add address, border to visit card amaljosea/journal
3 participants
@unnitallman @agneym @amaljosea