Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtype list not appearing properly when editing character #224

Closed
SpeedyD opened this issue Dec 14, 2021 · 1 comment
Closed

Subtype list not appearing properly when editing character #224

SpeedyD opened this issue Dec 14, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@SpeedyD
Copy link
Contributor

SpeedyD commented Dec 14, 2021

Bug as reported:

(Main branch, last commit parent: f447da64)

URL of page: <siteurl>/character/<slug>
Description of bug: Attempting to edit the subtype of a character makes the subtype not show up.
How was the bug caused (exact steps to reproduce): Go to any character page, click the Edit button on the Info tab, discover that the Subtype list still says 'Pick a Species First' even though it's an existing character with a species set already.

Further details

Fairly minor bug, was gonna attempt to fix it myself but got too busy unfortunately.

TL;DR the Subtype list doesn't fill up when you edit a character, even if it has a Species picked already. Seems fairly straightforward, just needs to trigger the refresh once the Modal opens, instead of waiting until someone swaps the Species.

@itinerare itinerare added the bug Something isn't working label Dec 14, 2021
@itinerare itinerare added this to the v2.1.0 milestone Dec 19, 2021
SpeedyD added a commit to SpeedyD/lorekeeper that referenced this issue Dec 20, 2021
@SpeedyD
Copy link
Contributor Author

SpeedyD commented Jan 15, 2023

Feature added in PR #229, part of the develop branch. (v3.0.0 milestone.)

@SpeedyD SpeedyD closed this as completed Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants