Feature/expand account authentication #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ability to choose the initial site linked from the primary ones available in the sites config
- Aliases management in user settings
- Change primary alias, hide non-primary aliases, remove non-primary aliases
- By default it's possible to link multiple accounts on the same site (but not the same account multiple times)
- List of aliases linked in sidebar on user profile page - non-paginated for now as it seems unlikely to become a very long page
Misc
- Changed fullName in sites config to full_name
- Slightly adjusted user admin panel page visually to handle page length better
.env must be updated to contain:
DEVIANTART_CLIENT_ID=
DEVIANTART_CLIENT_SECRET=
TWITTER_CLIENT_ID=
TWITTER_CLIENT_SECRET=
INSTAGRAM_CLIENT_ID=
INSTAGRAM_CLIENT_SECRET=
TUMBLR_CLIENT_ID=
TUMBLR_CLIENT_SECRET=
IMGUR_CLIENT_ID=
IMGUR_CLIENT_SECRET=
TWITCH_CLIENT_ID=
TWITCH_CLIENT_SECRET=
as required. It should be safe to leave out providers that will not be used for authentication.
Currently putting the redirect URIs into the services.php file - if this causes any issues (not seeing any on local testing), they can be added into .env as an additional {PROVIDER}_REDIRECT_URI field, like so:
DEVIANTART_REDIRECT_URI=/auth/callback/deviantart
itinerare
approved these changes
May 4, 2021
itinerare
requested changes
May 4, 2021
app/Models/User/UserAlias.php
Outdated
| @@ -52,7 +69,7 @@ public function user() | |||
| public function getUrlAttribute() | |||
| { | |||
| if($this->site == 'tumblr') return 'https://'.$this->alias.Config::get('lorekeeper.sites.tumblr.link'); | |||
| else return 'https://'.Config::get('lorekeeper.sites.'.$this->site.'.link').'/'.$this->alias; | |||
| else return 'https://'.Config::get('lorekeeper.sites.'.$this->siteDisplayName.'.link').'/'.$this->alias; | |||
There was a problem hiding this comment.
Needs to be changed back to $this->site I believe; this is consistent with the command to adjust dA aliases already on file
Draginraptor
approved these changes
May 5, 2021
itinerare
approved these changes
May 5, 2021
itinerare
approved these changes
May 5, 2021
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication of various other social media sites
Misc
.env must be updated to contain:
as required. It should be safe to leave out providers that will not be used for authentication.
Currently putting the redirect URIs into the services.php file - if this causes any issues (not seeing any on local testing), they can be added into .env as an additional {PROVIDER}_REDIRECT_URI field, like so:
DEVIANTART_REDIRECT_URI=/auth/callback/deviantart