Re-reduce dA request scope to only username #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other providers may need to be adjusted as appropriate in the future.
preimpression
approved these changes
May 24, 2021
Draginraptor
approved these changes
May 24, 2021
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with #12, but updated to suit the new system. Other providers may need to be adjusted as appropriate in the future; however, I do not know their scopes offhand. The basic method should work for each, however-- setScopes() overwrites scopes specified within the individual provider packages and so is a ready way to curtail any unnecessary access without needing to modify things at/around the package level.
Tested live, no further actions necessary.