Fix bug that occurs on items page in cases where the artist_url column is null #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…develop # Conflicts: # app/Helpers/Helpers.php
itinerare
approved these changes
Jul 8, 2021
Draginraptor
approved these changes
Jul 8, 2021
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://127.0.0.1:8000/world/items bug
this is needed due to PREG_SET_ORDER
and because no check occurs on the item artist attribute
// Check to see if the artist exists on site $artist = checkAlias($this->artist_url, false); // <---- here if(is_object($artist)) { $this->artist_id = $artist->id; $this->artist_url = null; $this->save(); }