Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extension/admin logs (also merging of latest release/release-2.0.0) #135

Merged
merged 8 commits into from
Sep 4, 2021
Merged

feat: Extension/admin logs (also merging of latest release/release-2.0.0) #135

merged 8 commits into from
Sep 4, 2021

Conversation

Ne-wt
Copy link
Contributor

@Ne-wt Ne-wt commented Jul 23, 2021

discussed on disc, the ONLY thing i can think of potentially being an issue is $user not being defined in an area i may have missed though I tried my best to test everywhere I added it. May also be some spots that should have logging that I've neglected

@Ne-wt
Copy link
Contributor Author

Ne-wt commented Jul 23, 2021

just remembered I need to add user edit logs - will add asap so this is just a draft as a ''don't forget newt''

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Jul 23, 2021
@Ne-wt Ne-wt marked this pull request as ready for review July 23, 2021 15:25
preimpression
preimpression suggested changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@preimpression preimpression left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much all just proofreading for typos! I checked Google on them to see if they were just Europe vs US but that didn't seem to be the case.

app/Http/Controllers/Admin/Users/UserController.php Outdated Show resolved Hide resolved
app/Services/CharacterCategoryService.php Outdated Show resolved Hide resolved
app/Services/CurrencyManager.php Outdated Show resolved Hide resolved
app/Services/CurrencyService.php Outdated Show resolved Hide resolved
app/Services/GalleryManager.php Outdated Show resolved Hide resolved
app/Services/ItemService.php Outdated Show resolved Hide resolved
Draginraptor
Draginraptor reviewed Sep 2, 2021
View reviewed changes
Copy link
Collaborator

@Draginraptor Draginraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd been waiting for the typo fixes Uri had pointed out, but I otherwise think that the code looks fine?

@Ne-wt
Copy link
Contributor Author

Ne-wt commented Sep 2, 2021

lol i forgot to fix those honestly, will get to it asap

@itinerare itinerare merged commit 20e9495 into corowne:develop Sep 4, 2021
@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Draginraptor Draginraptor Draginraptor approved these changes

@preimpression preimpression preimpression approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ne-wt @Draginraptor @preimpression @itinerare