Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sales): 'is open' for chars even when only one #145

Conversation

itinerare
Copy link
Collaborator

@itinerare itinerare commented Aug 24, 2021

More a UX fix than anything; hides the "is open" toggle for sales characters if there's only one character attached to the sales post, since it's largely relevant when there are multiple characters associated.

No action necessary; tested live.

@itinerare itinerare added the needs review Pull requests that are pending community review label Aug 24, 2021
@itinerare itinerare added this to the v2.0.0 milestone Aug 30, 2021
@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Sep 2, 2021
@itinerare itinerare merged commit 3bb7eb5 into corowne:release/release-2.0.0 Sep 2, 2021
@itinerare itinerare deleted the feature/sales-char-open-toggle-smart-vis branch September 2, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants