Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(characters): move design update functions to own service #188

Merged

Conversation

itinerare
Copy link
Collaborator

Splits up CharacterManager as previously discussed in a bid to make it less onerous to work with it.
I'd rather like this to get tested more, but on paper it's pretty cut and dry since it's just redirecting traffic as it were. No further action should be necessary, of course.

@itinerare itinerare added the needs review Pull requests that are pending community review label Oct 3, 2021
@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Oct 7, 2021
@itinerare itinerare merged commit 94f336f into corowne:develop Oct 7, 2021
@itinerare itinerare deleted the feature/add-design-update-manager branch October 7, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants