-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes and updates #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some things I'd like to rework in comments (taking PHP code out of the views, reducing the number of modals, removing recursive querying) but I'll wait till Newt's PR has been integrated to reduce conflicts.
itinerare
requested review from
itinerare and
Draginraptor
and removed request for
Draginraptor and
itinerare
October 17, 2021 12:34
# Conflicts: # resources/views/comments/_comment.blade.php # resources/views/user/profile.blade.php
…er. Users without the maintenance access power will get redirected to the home page.
itinerare
reviewed
Oct 23, 2021
I think this is good enough, the other changes would take a while longer to do and I don't want to push any more functionality changes now! |
itinerare
approved these changes
Oct 23, 2021
preimpression
approved these changes
Oct 23, 2021
Draginraptor
approved these changes
Oct 24, 2021
itinerare
added
reviewed
Pull requests that have received community review and are pending merge
and removed
needs review
Pull requests that are pending community review
labels
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
reviewed
Pull requests that have received community review and are pending merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing the code body in general, putting in some minor changes that are mostly small fixes and stylistic changes for consistency (coding/visually/English; will be...quite...pedantic). Still WIP.
<br>
s in favour of marginsTodo:
Notes on consistency:
<hr />, <br />, <img src="" />
rather than<hr>, <br>, <img src="">
)<br>
slide, but use margins in place of<br><br>
(the Bootstrap mt-3, mb-3 classes can be used for this){!! Form::open() !!}
and{!! Form::close() !!}
tags should be counted as open/close tags.{!! Form::open() !!}
and{!! Form::close() !!}
preferred to<form></form>
tags; the former also automatically includes the CSRF token so it's not needed.style
attribute in HTML tags (this will override custom CSS), make it classes as far as possible (would say that elements that use a lot of Bootstrap classes should also be converted to CSS in lorekeeper.css, as the Bootstrap classes have !important on them and may be annoying for users to customise)