Track composer.lock #250
Merged
Track composer.lock #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itinerare
force-pushed
the
feature/track-lock-file
branch
from
35730d4
to
cda056b
Compare
preimpression
approved these changes
Feb 1, 2022
Sabriel-Koh
approved these changes
Feb 13, 2022
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The composer.lock file should really be tracked, as it helps ensure consistency of package versions and reduces the amount of variance, for instance helping for any issues arising from diff dependency versions to be more easily tracked and resolved... Even for sites with different packages, standardizing tracking it across the board helps ensure their local and live environments are using the same versions of packages, etc.
I've run
composer updateprior to committing, so should be appropriately representative of the current state of develop's dependencies