Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension/deactivate account #296

Merged
merged 8 commits into from
Jun 14, 2022

Conversation

preimpression
Copy link
Contributor

Ability to deactivate account
I think there was one little conflict that I can fix up

@preimpression preimpression marked this pull request as ready for review April 6, 2022 22:51
@preimpression
Copy link
Contributor Author

"one conflict" = 11 conflicts apparently

@itinerare itinerare marked this pull request as draft April 6, 2022 23:38
@itinerare
Copy link
Collaborator

I'm marking this as draft-- feel free to pop it out of draft status once the conflicts are resolved!

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Apr 6, 2022
@itinerare itinerare added this to the v2.1.0 milestone Apr 6, 2022
# Conflicts:
#	app/Console/Commands/AddSiteSettings.php
#	app/Http/Controllers/BrowseController.php
#	app/Http/Controllers/Users/AccountController.php
#	app/Http/Controllers/Users/UserController.php
#	app/Models/Notification.php
#	app/Models/User/User.php
#	app/Models/User/UserSettings.php
#	app/Services/UserService.php
#	config/lorekeeper/extension_tracker.php
#	resources/views/browse/users.blade.php
#	resources/views/user/profile.blade.php
@preimpression preimpression marked this pull request as ready for review May 5, 2022 00:22
@preimpression
Copy link
Contributor Author

Fixed conflicts! Will note though that the workflow file will need to be re-added since I can't push to github with it, despite having the workflows permissions

app/Http/Controllers/Users/AccountController.php Outdated Show resolved Hide resolved
app/Services/UserService.php Outdated Show resolved Hide resolved
app/Services/UserService.php Show resolved Hide resolved
resources/views/account/_deactivate_confirmation.blade.php Outdated Show resolved Hide resolved
resources/views/account/deactivated.blade.php Outdated Show resolved Hide resolved
resources/views/pages/credits.blade.php Outdated Show resolved Hide resolved
@preimpression
Copy link
Contributor Author

Not sure what to do about the format_php workflow since I am currently unable to push that file to my github. Gonna try to redo all my auth stuff to get it to work and allow it

@itinerare
Copy link
Collaborator

I'm not sure what's to be done about it since it seems to be a sourcetree issue.... it's annoying, though. Since it perceives it as a conflict I can probably override it for this PR however

@preimpression
Copy link
Contributor Author

What's odd is it's not just sourcetree, if I try to push via VSC itself it gives the same issue, so evidently it's my account.
Also, about to pull the current develop into this branch too.

@itinerare
Copy link
Collaborator

Weird. I've just handled it for the moment, so you can handle it being uncooperative on your own time

@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Jun 14, 2022
@itinerare itinerare merged commit 3c84c39 into corowne:develop Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants