Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retroactive watermarking command #301

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Conversation

Ne-wt
Copy link
Contributor

@Ne-wt Ne-wt commented Apr 17, 2022

No description provided.

@itinerare
Copy link
Collaborator

itinerare commented Apr 17, 2022

Hmm, it might be worth taking a look at the function in CharacterManager? iirc? that processes the image instead of just applying the watermark directly since there's a lot of considerations that get taken into account there
Also, thinking about thumbnails maybe

@itinerare itinerare added enhancement New feature or request needs review Pull requests that are pending community review labels Apr 17, 2022
@Ne-wt
Copy link
Contributor Author

Ne-wt commented Apr 17, 2022

Hmm, it might be worth taking a look at the function in CharacterManager? iirc? that processes the image instead of just applying the watermark directly since there's a lot of considerations that get taken into account there Also, thinking about thumbnails maybe

good point! added in next commit

@itinerare itinerare changed the base branch from main to develop April 17, 2022 14:14
@itinerare itinerare added this to the v2.1.0 milestone Apr 17, 2022
@itinerare itinerare added reviewed Pull requests that have received community review and are pending merge and removed needs review Pull requests that are pending community review labels Apr 29, 2022
@itinerare itinerare merged commit 1b3bbc2 into corowne:develop Apr 29, 2022
tess-cos pushed a commit to tess-cos/lorekeeper that referenced this pull request May 18, 2024
* copy paste mistake fix
* remove tabs changing with navtextColor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants