Fixes Character Selection being unclear #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A fair change! Might be worth updating the sales post and gallery submission versions of that setup as well... |
|
@itinerare Good call! I just pushed an update to those two files as well. I think I'll leave the change I made in the copied file since it's there already, haha. |
|
Sounds good, and fair enough! |
itinerare
approved these changes
May 2, 2022
Ne-wt
approved these changes
May 3, 2022
preimpression
approved these changes
May 3, 2022
Draginraptor
approved these changes
May 4, 2022
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with making prompts, and ended up getting very confused when I kept getting the "Character does not exist" error on submission.
Turns out I kept thinking I had to click the "Add Character" button to get the character's details to populate in after entering the code, when I really should have just been clicking outside of the input.
For me that really doesn't feel intuitive, and so this is a tiny bug fix / feature? that changes the character selection input to be "onInput" rather than "onChange" so it updates as a user is typing. It does mean that you get an inline error about the character not existing until you've finished typing the code, but I find that to be more helpful.
I made this change to
_character_select_js.blade copy.phpto be thorough, although I'll be honest I don't know what the copy is used for.